Move BulkItemRequest BWC to 5.x#25511
Merged
bleskes merged 9 commits intoelastic:masterfrom Jul 8, 2017
Merged
Conversation
dakrone
approved these changes
Jul 5, 2017
Member
dakrone
left a comment
dakrone
left a comment
There was a problem hiding this comment.
LGTM (with of course the 5.x counterpart)
Contributor
Author
Contributor
Author
|
Thx @jasontedor |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current BWC code in
BulkItemRequestmutates the underlyingDocWriteRequestswhich causes test failures and unexpected state (our test infra checks bwc serialization on the fly). This PR removes this logic from master. Another PR will add a BWC layer to 5.x only.This PR contains the logic in #25510 , which is needed to run the tests.